Fix function pointer type mismatch for strict C compilers#246
Open
kevinscollins wants to merge 1 commit intoruby-numo:masterfrom
Open
Fix function pointer type mismatch for strict C compilers#246kevinscollins wants to merge 1 commit intoruby-numo:masterfrom
kevinscollins wants to merge 1 commit intoruby-numo:masterfrom
Conversation
Modern C compilers (particularly gcc with -std=c23 or Alpine's musl gcc) are stricter about function pointer type compatibility. This fixes a compilation error where loop_func parameter type didn't match the struct member declaration. Error was: ndloop.c:359:19: error: assignment to 'void (*)(void)' from incompatible pointer type The struct member at line 59 uses 'struct NA_MD_LOOP *' (forward declaration within the typedef), while the function parameter at line 334 used 'na_md_loop_t *'. Although these are the same type after typedef expansion, strict compilers require exact signature matching for function pointer assignments. Changed line 334 to use 'struct NA_MD_LOOP *' to match the struct member declaration, resolving the type incompatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modern C compilers (particularly gcc with -std=c23 or Alpine's musl gcc) are stricter about function pointer type compatibility. This fixes a compilation error where loop_func parameter type didn't match the struct member declaration.
Error was:
The struct member at line 59 uses 'struct NA_MD_LOOP *' (forward declaration within the typedef), while the function parameter at line 334 used 'na_md_loop_t *'. Although these are the same type after typedef expansion, strict compilers require exact signature matching for function pointer assignments.
Changed line 334 to use 'struct NA_MD_LOOP *' to match the struct member declaration, resolving the type incompatibility.